linux-kernel - Re: [PATCH 0/1] Replace DEFINE_PCI_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Aug 2014 12:44:21 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Benoit Taine <benoit.taine@...6.fr>
Cc:	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 0/1] Replace DEFINE_PCI_DEVICE_TABLE macro use

On Fri, Aug 08, 2014 at 03:56:02PM +0200, Benoit Taine wrote:
> We should prefer `const struct pci_device_id` over
> `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
> This issue was reported by checkpatch.
> 
> A simplified version of the semantic patch that makes this change is as
> follows (http://coccinelle.lip6.fr/):
> 
> // <smpl>
> 
> @@
> identifier i;
> declarer name DEFINE_PCI_DEVICE_TABLE;
> initializer z;
> @@
> 
> - DEFINE_PCI_DEVICE_TABLE(i)
> + const struct pci_device_id i[]
> = z;
> 
> // </smpl>
> 
> I previously sent parts of this patch to check wether or not it was
> worth sending, and Bjorn answered:
> > Benoit, how about if you wait until about half-way through the merge
> > window after v3.16 releases, generate an up-to-date single patch, and
> > post that?  Then we can try to get it in before v3.17-rc1 to minimize
> > merge hassles.
> 
> So here it is, based on linux-next on 2014-08-07.

Applied to my for-linus branch for v3.17, thanks!

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/