linux-kernel - RE: [PATCH v2] uas: replace WARN_ON_ONCE() with lockdep_assert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Aug 2014 06:28:39 +0000
From:	"Sharma, Sanjeev" <Sanjeev_Sharma@...tor.com>
To:	Greg KH <gregkh@...uxfoundation.org>
CC:	"hdegoede@...hat.com" <hdegoede@...hat.com>,
	"kraxel@...hat.com" <kraxel@...hat.com>,
	"mdharm-usb@...-eyed-alien.net" <mdharm-usb@...-eyed-alien.net>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: RE: [PATCH v2] uas: replace WARN_ON_ONCE() with
 lockdep_assert_held()

Done !

Thanks
Sanjeev Sharma

-----Original Message-----
From: Greg KH [mailto:gregkh@...uxfoundation.org] 
Sent: Tuesday, August 12, 2014 11:32 AM
To: Sharma, Sanjeev
Cc: hdegoede@...hat.com; kraxel@...hat.com; mdharm-usb@...-eyed-alien.net; linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org; linux-scsi@...r.kernel.org
Subject: Re: [PATCH v2] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

On Tue, Aug 12, 2014 at 11:38:37AM +0530, Sanjeev Sharma wrote:
> spin_is_locked() always return false in uniprocessor configuration and 
> therefore it would be advise to replace with lockdep_assert_held().

Add "on some architectures" in here somewhere, as it's not broken on the large majority of UP cpus :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/