linux-kernel - Re: [PATCH 10/19] ath6kl: fix %d confusingly prefixed with 0x in format strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Aug 2014 15:38:54 +0300
From:	Kalle Valo <kvalo@....qualcomm.com>
To:	Hans Wennborg <hans@...shq.net>
CC:	<linville@...driver.com>, <linux-wireless@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <ath6kl@...ts.infradead.org>
Subject: Re: [PATCH 10/19] ath6kl: fix %d confusingly prefixed with 0x in format strings

Hans Wennborg <hans@...shq.net> writes:

> Signed-off-by: Hans Wennborg <hans@...shq.net>
> ---
>  drivers/net/wireless/ath/ath6kl/init.c | 2 +-
>  drivers/net/wireless/ath/ath6kl/main.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c
> index fffd523..91af845 100644
> --- a/drivers/net/wireless/ath/ath6kl/init.c
> +++ b/drivers/net/wireless/ath/ath6kl/init.c
> @@ -1049,7 +1049,7 @@ static int ath6kl_fetch_fw_apin(struct ath6kl *ar, const char *name)
>  			ar->hw.reserved_ram_size = le32_to_cpup(val);
>  
>  			ath6kl_dbg(ATH6KL_DBG_BOOT,
> -				   "found reserved ram size ie 0x%d\n",
> +				   "found reserved ram size ie 0x%x\n",
>  				   ar->hw.reserved_ram_size);

Actually the original intent here was to use %d.

> diff --git a/drivers/net/wireless/ath/ath6kl/main.c b/drivers/net/wireless/ath/ath6kl/main.c
> index 21516bc..933aef0 100644
> --- a/drivers/net/wireless/ath/ath6kl/main.c
> +++ b/drivers/net/wireless/ath/ath6kl/main.c
> @@ -225,7 +225,7 @@ int ath6kl_diag_write32(struct ath6kl *ar, u32 address, __le32 value)
>  	ret = ath6kl_hif_diag_write32(ar, address, value);
>  
>  	if (ret) {
> -		ath6kl_err("failed to write 0x%x during diagnose window to 0x%d\n",
> +		ath6kl_err("failed to write 0x%x during diagnose window to 0x%x\n",
>  			   address, value);

This is ok.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/