linux-kernel - Re: [RFC PATCH] ipmi/of: Don't use unavailable interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 16 Aug 2014 19:25:30 -0500
From:	Corey Minyard <minyard@....org>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Rob Herring <rob.herring@...xeda.com>
CC:	Grant Likely <grant.likely@...retlab.ca>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] ipmi/of: Don't use unavailable interfaces

On 08/14/2014 01:39 AM, Benjamin Herrenschmidt wrote:
> If an IPMI controller is used by the firmware and as such marked with
> a reserved status, we shouldn't use it.

I've added this to my IPMI tree.  I can't comment on it's correctness,
others would know better than me, but it seems reasonable.

Thanks,

-corey

> Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> ---
>
> Not tested, found by inspection as we are investigating how to plumb
> IPMI on one of our future platforms. Our FW uses the device-tree for
> its own internal use and tags stuff that it reserves for itself using
> the "status" property. This is likely to be the case of our BT interface.
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 5d66568..4fc8931 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -2658,6 +2658,9 @@ static int ipmi_probe(struct platform_device *dev)
>  	if (!match)
>  		return -EINVAL;
>  
> +	if (!of_device_is_available(np))
> +		return -EINVAL;
> +
>  	ret = of_address_to_resource(np, 0, &resource);
>  	if (ret) {
>  		dev_warn(&dev->dev, PFX "invalid address from OF\n");
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/