linux-kernel - Re: [PATCH] ARM: dts: DRA7: fix interrupt-cells for GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Aug 2014 13:46:11 -0500
From:	Nishanth Menon <nm@...com>
To:	<tony@...mide.com>
CC:	<devicetree@...r.kernel.org>,
	<inux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: DRA7: fix interrupt-cells for GPIO

On 07/30/2014 02:20 PM, Nishanth Menon wrote:
> GPIO modules are also interrupt sources. However, they require both the
> GPIO number and IRQ type to function properly.
> 
> By declaring that GPIO uses interrupt-cells=<1>, we essentially do not
> allow users of the nodes to use the interrupt property appropritely.
> 
> With this change, the following now works:
> 
> interrupt-parent = <&gpio6>;
> interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
> 
> Fixes: 6e58b8f1daaf ('ARM: dts: DRA7: Add the dts files for dra7 SoC and dra7-evm board')
> Signed-off-by: Nishanth Menon <nm@...com>
> ---
> Based on v3.16-rc7
> 
>  arch/arm/boot/dts/dra7.dtsi |   16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

Tony,
Gentle ping. we still have this issue on 3.17-rc1. any suggestions on
if we can pick this up during RC?

> 
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 8012763..f21ef39 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -172,7 +172,7 @@
>  			gpio-controller;
>  			#gpio-cells = <2>;
>  			interrupt-controller;
> -			#interrupt-cells = <1>;
> +			#interrupt-cells = <2>;
>  		};
>  
>  		gpio2: gpio@...55000 {
> @@ -183,7 +183,7 @@
>  			gpio-controller;
>  			#gpio-cells = <2>;
>  			interrupt-controller;
> -			#interrupt-cells = <1>;
> +			#interrupt-cells = <2>;
>  		};
>  
>  		gpio3: gpio@...57000 {
> @@ -194,7 +194,7 @@
>  			gpio-controller;
>  			#gpio-cells = <2>;
>  			interrupt-controller;
> -			#interrupt-cells = <1>;
> +			#interrupt-cells = <2>;
>  		};
>  
>  		gpio4: gpio@...59000 {
> @@ -205,7 +205,7 @@
>  			gpio-controller;
>  			#gpio-cells = <2>;
>  			interrupt-controller;
> -			#interrupt-cells = <1>;
> +			#interrupt-cells = <2>;
>  		};
>  
>  		gpio5: gpio@...5b000 {
> @@ -216,7 +216,7 @@
>  			gpio-controller;
>  			#gpio-cells = <2>;
>  			interrupt-controller;
> -			#interrupt-cells = <1>;
> +			#interrupt-cells = <2>;
>  		};
>  
>  		gpio6: gpio@...5d000 {
> @@ -227,7 +227,7 @@
>  			gpio-controller;
>  			#gpio-cells = <2>;
>  			interrupt-controller;
> -			#interrupt-cells = <1>;
> +			#interrupt-cells = <2>;
>  		};
>  
>  		gpio7: gpio@...51000 {
> @@ -238,7 +238,7 @@
>  			gpio-controller;
>  			#gpio-cells = <2>;
>  			interrupt-controller;
> -			#interrupt-cells = <1>;
> +			#interrupt-cells = <2>;
>  		};
>  
>  		gpio8: gpio@...53000 {
> @@ -249,7 +249,7 @@
>  			gpio-controller;
>  			#gpio-cells = <2>;
>  			interrupt-controller;
> -			#interrupt-cells = <1>;
> +			#interrupt-cells = <2>;
>  		};
>  
>  		uart1: serial@...6a000 {
> 


-- 
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/