linux-kernel - Re: [PATCH] flush_icache_range: Export symbol to fix build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Aug 2014 10:35:36 +0400
From:	Max Filippov <jcmvbkbc@...il.com>
To:	Pranith Kumar <bobby.prani@...il.com>
Cc:	Vineet Gupta <vgupta@...opsys.com>,
	Steven Miao <realmz6@...il.com>,
	David Howells <dhowells@...hat.com>,
	Richard Kuo <rkuo@...eaurora.org>,
	James Hogan <james.hogan@...tec.com>,
	Chris Metcalf <cmetcalf@...era.com>,
	Chris Zankel <chris@...kel.net>, Noam Camus <noamc@...hip.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Tony Lu <zlu@...era.com>, Kirill Tkhai <tkhai@...dex.ru>,
	open list <linux-kernel@...r.kernel.org>,
	"moderated list:BLACKFIN ARCHITEC..." 
	<adi-buildroot-devel@...ts.sourceforge.net>,
	"open list:QUALCOMM HEXAGON..." <linux-hexagon@...r.kernel.org>,
	"open list:METAG ARCHITECTURE" <linux-metag@...r.kernel.org>,
	"open list:SUPERH" <linux-sh@...r.kernel.org>,
	"open list:TENSILICA XTENSA..." <linux-xtensa@...ux-xtensa.org>
Subject: Re: [PATCH] flush_icache_range: Export symbol to fix build errors

Hi Pranith,

On Mon, Aug 18, 2014 at 8:24 AM, Pranith Kumar <bobby.prani@...il.com> wrote:
> Fix building errors occuring due to a missing export of flush_icache_range() in
> architectures missing the export.

Can you be a little more specific here, what build errors?

[...]

> diff --git a/arch/frv/include/asm/cacheflush.h b/arch/frv/include/asm/cacheflush.h
> index edbac54..07ee4b3 100644
> --- a/arch/frv/include/asm/cacheflush.h
> +++ b/arch/frv/include/asm/cacheflush.h
> @@ -72,6 +72,7 @@ static inline void flush_icache_range(unsigned long start, unsigned long end)
>  {
>         frv_cache_wback_inv(start, end);
>  }
> +EXPORT_SYMBOL(flush_icache_range);

EXPORT_SYMBOL should not be placed into header file as it defines
a non-static variable.

[...]

> diff --git a/arch/metag/include/asm/cacheflush.h b/arch/metag/include/asm/cacheflush.h
> index 7787ec5..117c212 100644
> --- a/arch/metag/include/asm/cacheflush.h
> +++ b/arch/metag/include/asm/cacheflush.h
> @@ -124,6 +124,7 @@ static inline void flush_icache_range(unsigned long address,
>         metag_code_cache_flush((void *) address, endaddr - address);
>  #endif
>  }
> +EXPORT_SYMBOL(flush_icache_range);

Same here.

-- 
Thanks.
-- Max
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/