linux-kernel - Re: [PATCH] arch/microblaze/include/asm/entry.h: Include "linux/linkage.h" to avoid compiling issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Aug 2014 23:47:44 +0800
From:	Chen Gang <gang.chen.5i5j@...il.com>
To:	Michal Simek <monstr@...str.eu>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arch/microblaze/include/asm/entry.h: Include "linux/linkage.h"
 to avoid compiling issue

Hello maintainers:

Please help check the related 2 patches when you have time.

Thanks.

On 08/06/2014 09:32 PM, Chen Gang wrote:
> "entry.h" needs 'asmlinkage', and "asm/linkage.h" does not provide it.
> So need include "linux/linkage.h" to use generic one instead of.
> 
> The related error (with allmodconfig under microblaze):
> 
>     CC [M]  drivers/net/ethernet/emulex/benet/be_main.o
>   In file included from ./arch/microblaze/include/asm/processor.h:17:0,
>                    from include/linux/prefetch.h:14,
>                    from drivers/net/ethernet/emulex/benet/be_main.c:18:
>   ./arch/microblaze/include/asm/entry.h:33:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'void'
>    extern asmlinkage void do_notify_resume(struct pt_regs *regs, int in_syscall);
>                      ^
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
> ---
>  arch/microblaze/include/asm/entry.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/microblaze/include/asm/entry.h b/arch/microblaze/include/asm/entry.h
> index b4a4cb1..596e485 100644
> --- a/arch/microblaze/include/asm/entry.h
> +++ b/arch/microblaze/include/asm/entry.h
> @@ -15,6 +15,7 @@
>  
>  #include <asm/percpu.h>
>  #include <asm/ptrace.h>
> +#include <linux/linkage.h>
>  
>  /*
>   * These are per-cpu variables required in entry.S, among other
> 


-- 
Chen Gang

Open share and attitude like air water and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/