linux-kernel - Re: [PATCH v4 2/2] usb: dwc2: add 'mode' which based on Kconfig select or dts setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 19 Aug 2014 11:56:37 -0700
From:	Doug Anderson <dianders@...omium.org>
To:	Kever Yang <kever.yang@...k-chips.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Paul Zimmerman <paulz@...opsys.com>,
	Heiko Stuebner <heiko@...ech.de>,
	Addy Ke <addy.ke@...k-chips.com>,
	Eddie Cai <cf@...k-chips.com>, Jianqun Xu <xjq@...k-chips.com>,
	Olof Johansson <olof@...om.net>,
	Sonny Rao <sonnyrao@...omium.org>, wulf <wulf@...k-chips.com>,
	lyz <lyz@...k-chips.com>, Jingoo Han <jg1.han@...sung.com>,
	han jiang <hj@...k-chips.com>,
	Tao Huang <huangtao@...k-chips.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 2/2] usb: dwc2: add 'mode' which based on Kconfig
 select or dts setting

Kever,

On Tue, Aug 5, 2014 at 6:01 PM, Kever Yang <kever.yang@...k-chips.com> wrote:
> According to the "dr_mode", the otg controller can work as
> device role and host role. Some boards always want to use host mode
> and some other boards want to use gadget mode. We use the dts setting
> to set dwc2's mode, rather than fixing it to whatever hardware says.
>
> Signed-off-by: Kever Yang <kever.yang@...k-chips.com>
> Acked-by: Paul Zimmerman <paulz@...opsys.com>
> ---
>
> Changes in v4:
> - From Doug's suggestion:
>  -- remove dr_mode init from Kconfig code
>  -- change the commit meesage
>
> Changes in v3:
> - fix the odd spacing in dwc2_hsotg struct
> - From Jingoo's suggestion:
>     change the commit message
> - add dr_mode init from Kconfig
>
> Changes in v2:
> - put spaces around '+' operator
> - expand the comment for dr_mode
> - handle dr_mode is USB_DR_MODE_OTG
>
>  drivers/usb/dwc2/core.c     | 18 ++++++++++++++++++
>  drivers/usb/dwc2/core.h     |  5 +++++
>  drivers/usb/dwc2/platform.c |  4 ++++
>  3 files changed, 27 insertions(+)

In case it's useful, I've actually tested myself that this is
necessary and sufficient to get the OTG port to behave properly as a
host port on an rk3288 board.

Tested-by: Doug Anderson <dianders@...omium.org>


Greg: now that the merge window has closed, are you interested in
landing Kever's changes (with Paul's Ack).  There's this series and
another adding rk3288 support.  If you'd like Kever to repost with
Acks or want pointers to patches, please yell!  ;)

-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/