linux-kernel - Re: [PATCH v2] powerpc: booke_wdt: Fix build error as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Aug 2014 16:19:44 -0400
From:	Pranith Kumar <bobby.prani@...il.com>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	Wim Van Sebroeck <wim@...ana.be>,
	"open list:WATCHDOG DEVICE D..." <linux-watchdog@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] powerpc: booke_wdt: Fix build error as a module

On Wed, Aug 20, 2014 at 4:10 PM, Guenter Roeck <linux@...ck-us.net> wrote:
> On Wed, Aug 20, 2014 at 03:26:46PM -0400, Pranith Kumar wrote:
>> Building booke_wdt fails when trying to build as a module as there is no
>> early_param() in module. Fix by using module_param() instead of early_param().
>>
>> Signed-off-by: Pranith Kumar <bobby.prani@...il.com>
>> CC: Guenter Roeck <linux@...ck-us.net>
>
> Looks good as far as I can see. One question though:
>
>> +MODULE_ALIAS("booke_wdt");
>
> Is this necessary ? If yes, shouldn't it be a separate patch to be applied
> to -stable ?

Suppose this was actually built as a module. How do you pass the
module parameters to this module? Only ways I know of are

./insmod booke_wdt booke_wdt_enabled=1 booke_wdt_period=3

or pass booke_wdt.booke_wdt_enabled=1 on the kernel boot params list.

So the alias is necessary to refer to this module to pass params.

About separate patch, I think it is only with conversion to
module_param() that we need this alias.

Am I missing something?

-- 
Pranith
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/