linux-kernel - Re: [PATCH] gpio: omap: Fix interrupt names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Aug 2014 15:57:36 +0200
From:	Javier Martinez Canillas <javier@...hile0.org>
To:	Santosh Shilimkar <santosh.shilimkar@...com>
Cc:	Nishanth Menon <nm@...com>,
	Kevin Hilman <khilman@...prootsystems.com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	Linux GPIO List <linux-gpio@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: omap: Fix interrupt names

Hello,

On Thu, Aug 21, 2014 at 3:37 PM, Santosh Shilimkar
<santosh.shilimkar@...com> wrote:
> On Thursday 21 August 2014 09:19 AM, Nishanth Menon wrote:
>> When viewing the /proc/interrupts, there is no information about which
>> GPIO bank a specific gpio interrupt is hooked on to. This is more than a
>> bit irritating as such information can esily be provided back to the
>> user and at times, can be crucial for debug.
>>
>> So, instead of displaying something like:
>> 31:   0       0  GPIO   0  palmas
>> 32:   0       0  GPIO  27  mmc0
>>
>> Display the following with appropriate device name:
>> 31:   0       0  4ae10000.gpio   0  palmas
>> 32:   0       0  4805d000.gpio  27  mmc0
>>
>> This requires that we create irq_chip instance specific for each GPIO
>> bank which is trivial to achieve.
>>
>> Signed-off-by: Nishanth Menon <nm@...com>
>> ---
>> based on v3.17-rc1
> Looks good..
> Acked-by: Santosh Shilimkar <santosh.shilimkar@...com>
>

Looks good to me as well.

Acked-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/