| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Aug 2014 15:58:27 +0300 From: Andreea-Cristina Bernat <bernat.ada@...il.com> To: axboe@...nel.dk, linux-kernel@...r.kernel.org Cc: paulmck@...ux.vnet.ibm.com Subject: [PATCH] partition-generic: Replace rcu_assign_pointer() with RCU_INIT_POINTER() The uses of "rcu_assign_pointer()" are NULLing out the pointers. According to RCU_INIT_POINTER()'s block comment: "1. This use of RCU_INIT_POINTER() is NULLing out the pointer" it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead. The following Coccinelle semantic patch was used: @@ @@ - rcu_assign_pointer + RCU_INIT_POINTER (..., NULL) Signed-off-by: Andreea-Cristina Bernat <bernat.ada@...il.com> --- block/partition-generic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/partition-generic.c b/block/partition-generic.c index 789cdea..f1ef057 100644 --- a/block/partition-generic.c +++ b/block/partition-generic.c @@ -249,8 +249,8 @@ void delete_partition(struct gendisk *disk, int partno) if (!part) return; - rcu_assign_pointer(ptbl->part[partno], NULL); - rcu_assign_pointer(ptbl->last_lookup, NULL); + RCU_INIT_POINTER(ptbl->part[partno], NULL); + RCU_INIT_POINTER(ptbl->last_lookup, NULL); kobject_put(part->holder_dir); device_del(part_to_dev(part)); blk_free_devt(part_devt(part)); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists