| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Aug 2014 17:07:59 +0300 From: Andreea-Cristina Bernat <bernat.ada@...il.com> To: trond.myklebust@...marydata.com, linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org Cc: paulmck@...ux.vnet.ibm.com Subject: [PATCH] nfs: delegation: Replace rcu_assign_pointer() with RCU_INIT_POINTER() The use of "rcu_assign_pointer()" is NULLing out the pointer. According to RCU_INIT_POINTER()'s block comment: "1. This use of RCU_INIT_POINTER() is NULLing out the pointer" it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead. The following Coccinelle semantic patch was used: @@ @@ - rcu_assign_pointer + RCU_INIT_POINTER (..., NULL) Signed-off-by: Andreea-Cristina Bernat <bernat.ada@...il.com> --- fs/nfs/delegation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/delegation.c b/fs/nfs/delegation.c index 5d8ccec..349e63b 100644 --- a/fs/nfs/delegation.c +++ b/fs/nfs/delegation.c @@ -249,7 +249,7 @@ nfs_detach_delegation_locked(struct nfs_inode *nfsi, list_del_rcu(&delegation->super_list); delegation->inode = NULL; nfsi->delegation_state = 0; - rcu_assign_pointer(nfsi->delegation, NULL); + RCU_INIT_POINTER(nfsi->delegation, NULL); spin_unlock(&delegation->lock); return delegation; } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists