linux-kernel - Re: [PATCH v4] i2c: rk3x: fix bug that cause transfer fails in master receive mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Aug 2014 13:04:48 -0700
From:	Doug Anderson <dianders@...omium.org>
To:	addy ke <addy.ke@...k-chips.com>
Cc:	Wolfram Sang <wsa@...-dreams.de>, max.schwarz@...ine.de,
	Heiko Stübner <heiko@...ech.de>,
	Olof Johansson <olof@...om.net>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	sergei.shtylyov@...entembedded.com,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	linux-rockchip@...ts.infradead.org, Eddie Cai <cf@...k-chips.com>,
	Jianqun Xu <xjq@...k-chips.com>,
	Tao Huang <huangtao@...k-chips.com>,
	Chris <zyw@...k-chips.com>,
	姚智情 <yzq@...k-chips.com>,
	han jiang <hj@...k-chips.com>,
	Kever Yang <kever.yang@...k-chips.com>,
	Lin Huang <hl@...k-chips.com>,
	晓腾王 <caesar.wang@...k-chips.com>,
	Shunqian Zheng <zhengsq@...k-chips.com>
Subject: Re: [PATCH v4] i2c: rk3x: fix bug that cause transfer fails in master
 receive mode

Addy,

On Fri, Aug 22, 2014 at 11:47 AM, addy ke <addy.ke@...k-chips.com> wrote:
>> Addy,
>>
>> On Fri, Aug 22, 2014 at 11:00 AM, Addy Ke <addy.ke@...k-chips.com> wrote:
>>> In rk3x SOC, the I2C controller can receive/transmit up to 32 bytes data
>>> in one chunk, so the size of data to be write/read to/from TXDATAx/RXDATAx
>>> must be less than or equal 32 bytes at a time.
>>>
>>> Tested on rk3288-pinky board, elan receive 158 bytes data.
>>>
>>> Suggested-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
>>
>> You only need a "Suggested-by" if the entire patch was suggested by
>> someone.  If someone provides you review feedback you don't need it.
>>
>> Said another way: in this case Dmitry didn't suggest that you need to
>> fix the i2c controller to transmit 32 byte chunks (he only provided
>> review feedback), so you shouldn't say this was Suggested-by him.
>>
>> You also had my reviewed-by on a previous version so you could keep it.
>>
>> Reviewed-by: Doug Anderson <dianders@...omium.org>
>
> so, Do I need repost this patch or post a new one as patch v5?

Tags are typically something that the maintainer (Wolfram) can adjust
when he adds his own.  I think it's OK and he can remove the
"Suggested-by".  However, if Wolfram responds and asks you to respin
then you should follow his advice.


-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/