linux-kernel - Re: [RFC 3/4] tuntap: reduce the size of tun

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Aug 2014 11:35:11 +1000
From:	David Gibson <dgibson@...hat.com>
To:	Pankaj Gupta <pagupta@...hat.com>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	davem@...emloft.net, jasowang@...hat.com, mst@...hat.com,
	vfalico@...il.com, edumazet@...gle.com, vyasevic@...hat.com,
	hkchu@...gle.com, wuzhy@...ux.vnet.ibm.com, xemul@...allels.com,
	therbert@...gle.com, bhutchings@...arflare.com, xii@...gle.com,
	stephen@...workplumber.org
Subject: Re: [RFC 3/4] tuntap: reduce the size of tun_struct by using flex
 array

On Mon, 18 Aug 2014 19:07:19 +0530
Pankaj Gupta <pagupta@...hat.com> wrote:

> This patch switches to flex array to implement the flow caches, it brings
> several advantages:
> 
> - Reduce the size of the tun_struct structure, which allows us to increase the
>   upper limit of queues in future.
> - Avoid higher order memory allocation. It will be useful when switching to
>   pure hashing in flow cache which may demand a larger size array in future.
> 
> After this patch, the size of tun_struct on x86_64 reduced from 8512 to
> 328
> 
> Signed-off-by: Jason Wang <jasowang@...hat.com>
> Signed-off-by: Pankaj Gupta <pagupta@...hat.com>

Reviewed-by: David Gibson <dgibson@...hat.com>

-- 
David Gibson <dgibson@...hat.com>

Content of type "application/pgp-signature" skipped