linux-kernel - Re: [PATCH] thunderbolt: Clear hops before overwriting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 26 Aug 2014 18:02:19 +0200
From:	Andreas Noever <andreas.noever@...il.com>
To:	Greg KH <greg@...ah.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] thunderbolt: Clear hops before overwriting

On Tue, Aug 26, 2014 at 5:54 PM, Greg KH <greg@...ah.com> wrote:
> On Tue, Aug 26, 2014 at 05:42:21PM +0200, Andreas Noever wrote:
>> Zero hops in tb_path_activate before writing a new path.
>>
>> This fixes the following scenario:
>>  - Boot with a coldplugged device
>>  - Unplug device
>>  - Plug device back in
>>  - PCI hotplug fails
>>
>> The hotplug operation fails because our new path matches the (now
>> defunct) path which was setup by the firmware for the coldplugged
>> device. By writing zeros before writing our path configuration we can
>> force thunderbolt to retrain the path.
>>
>> Signed-off-by: Andreas Noever <andreas.noever@...il.com>
>> ---
>>  drivers/thunderbolt/path.c | 21 ++++++++++++++++++++-
>>  1 file changed, 20 insertions(+), 1 deletion(-)
>
> Should this get in for 3.17-final or can it wait for 3.18?  I'm thinking
> 3.17, but want to make sure.

I would prefer 3.17.

> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/