linux-kernel - Re: [PATCH v4 6/8] power: max17040: Add ID for MAX77836 Fuel Gauge block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 28 Aug 2014 13:42:05 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
	linux-pm@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH v4 6/8] power: max17040: Add ID for MAX77836 Fuel Gauge
 block

On Thu, 28 Aug 2014, Krzysztof Kozlowski wrote:

> On czw, 2014-08-28 at 12:52 +0100, Lee Jones wrote:
> > On Wed, 27 Aug 2014, Krzysztof Kozlowski wrote:
> > 
> > > MAX77836 has the same Fuel Gauge as MAX17040/17048. The max17040 driver
> > > can be safely re-used. The patch adds MAX77836 ID to array of
> > > i2c_device_id.
> > > 
> > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> > > Cc: Kyungmin Park <kyungmin.park@...sung.com>
> > > ---
> > >  drivers/power/max17040_battery.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/power/max17040_battery.c b/drivers/power/max17040_battery.c
> > > index 0fbac861080d..165ffe381803 100644
> > > --- a/drivers/power/max17040_battery.c
> > > +++ b/drivers/power/max17040_battery.c
> > > @@ -278,6 +278,7 @@ static SIMPLE_DEV_PM_OPS(max17040_pm_ops, max17040_suspend, max17040_resume);
> > >  
> > >  static const struct i2c_device_id max17040_id[] = {
> > >  	{ "max17040", 0 },
> > > +	{ "max77836-battery", 0 },
> > 
> > Are you sure you want the IDs to be the same?
> > 
> > If they are not used, just drop them entirely.
> 
> They are not used but you're right that the ID should be different. I'll
> add an local enum for the ID.

If they're not used, drop them.

 { "max17040" },
 { "max77836-battery" },

> > >  	{ }
> > >  };
> > >  MODULE_DEVICE_TABLE(i2c, max17040_id);
> > 
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/