lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 29 Aug 2014 02:50:39 +0200 From: Christoph Hellwig <hch@....de> To: Hannes Reinecke <hare@...e.de> Cc: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@...achi.com>, linux-scsi@...r.kernel.org, "Martin K. Petersen" <martin.petersen@...cle.com>, yrl.pp-manager.tt@...achi.com, linux-kernel@...r.kernel.org, "James E.J. Bottomley" <JBottomley@...allels.com>, Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>, Doug Gilbert <dgilbert@...erlog.com>, Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>, Christoph Hellwig <hch@....de> Subject: Re: [RFC PATCH 07/10] scsi/trace: Use scsi_show_result trace point instead of printk > I'm not sure this is the correct way. > Currently we have quite some code duplication in scsi_trace.c and > constants.c, correct. > So I definitely would like to see them both merged. > > But constants.c is influenced by CONFIG_SCSI_CONSTANTS, whereas > scsi_trace isn't, and the functions in constants.c are used throughout the > scsi stack. > So I'd rather see to have scsi_trace to be updated to use the functions > from constants.c, and remove the duplicate code in > scsi_trace. The tracepoints need to use the magic print_flags & co helpers so that output works properly if using the binary tracebuffer and user space tools that decoded it (e.g. trace-cmd or perf), so using a kernel function for decoding is not an option. But we can make these tracepoints dependent on CONFIG_SCSI_CONSTANTS to still allow building lighter kernels if we really care about it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists