linux-kernel - Re: [PATCH 0/5 v3] irq / PM: Suspend-to-idle wakeup interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Aug 2014 03:09:34 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
cc:	Peter Zijlstra <peterz@...radead.org>,
	Linux PM list <linux-pm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux PCI <linux-pci@...r.kernel.org>,
	Dmitry Torokhov <dtor@...gle.com>,
	Aubrey Li <aubrey.li@...el.com>
Subject: Re: [PATCH 0/5 v3] irq / PM: Suspend-to-idle wakeup interrupts

On Fri, 29 Aug 2014, Rafael J. Wysocki wrote:
> On Friday, August 29, 2014 12:44:11 AM Thomas Gleixner wrote:
> > So really, I'm too lazy to walk through that mess further. I bet NONE
> > of the usage sites except those for which this has been introduced in
> > the first place has a real good reason to do so.
> 
> A quite similar conclusion occured to me earlier today independently,
> so we seem to be in agreement here. :-)

I appreciate that!
 
> > Unless someone comes up with a use case where a shared NO_SUSPEND
> > handler is absolutely required, there is nothing which needs to be
> > addressed. You've proven yourself, that the wake mechanism is
> > sufficient to solve the problem which led to this discussion.
> 
> Yeah, that particular thing can be perfectly addressed without using
> IRQF_NO_SUSPEND.
> 
> There seems to be quite some confusion about that in the ARM world,
> though, as IRQF_NO_SUSPEND things *happen* to wake the system up if WFI is
> used to emulate "suspend" and that appears to make people believe that using
> them for this purpose is actually fine (because that appears to work).

Well, the problem in the ARM world is still the same as we had 10
years ago, just a bit different. While 10 years ago, the "make it work
for me" attitude was hidden in some vendor tree and stayed there
forever, today its still the same "make it work for me" thing which
gets applied to the vendor tree (they still sport 1000+ patches
despite all efforts) and then trickles into the mainline w/o much
review to fulfil the "we need to be mainline" mantra.
 
> That said I was not involved in the introduction of IRQF_EARLY_RESUME (or
> at least I can't recall being involved) and I also can't recall having used
> it for anything, so I can't really say what the original motivation was.

It was solely introduced to solve an oddball issue with the XEN "IPIs"
and I take the blame for not documenting it proper. Though I really
have a hard time to understand why random drivers use this w/o comment
and for no obvious reason. "Works for me" looks like a reasonable
explanation.

I've uploaded an incomplete and completely untested patch series to
handle this stuff to: https://tglx.de/~tglx/patches.tar

Feel free to pick it up and work from there.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/