linux-kernel - Re: [PATCH 2/3] x86: Enable PAT to use cache mode translation tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 29 Aug 2014 06:08:15 +0200
From:	Juergen Gross <jgross@...e.com>
To:	Toshi Kani <toshi.kani@...com>
CC:	stefan.bader@...onical.com, linux-kernel@...r.kernel.org,
	xen-devel@...ts.xensource.com, konrad.wilk@...cle.com,
	ville.syrjala@...ux.intel.com, hpa@...or.com, x86@...nel.org
Subject: Re: [PATCH 2/3] x86: Enable PAT to use cache mode translation tables

On 08/29/2014 01:21 AM, Toshi Kani wrote:
> On Tue, 2014-08-26 at 08:16 +0200, Juergen Gross wrote:
>> Update the translation tables from cache mode to pgprot values according to
>> the PAT settings. This enables changing the cache attributes of a PAT index in
>> just one place without having to change at the users side.
>>
>> With this change it is possible to use the same kernel with different PAT
>> configurations, e.g. supporting Xen.
>>
>> Signed-off-by: Juergen Gross <jgross@...e.com>
>
> I know I sent my review-by before, but my build test failed...
>
>> diff --git a/include/linux/mm.h b/include/linux/mm.h
>> index 8981cc8..d7bf551 100644
>> --- a/include/linux/mm.h
>> +++ b/include/linux/mm.h
>> @@ -1574,6 +1574,7 @@ extern void free_area_init(unsigned long * zones_size);
>>   extern void free_area_init_node(int nid, unsigned long * zones_size,
>>   		unsigned long zone_start_pfn, unsigned long *zholes_size);
>>   extern void free_initmem(void);
>> +extern void update_cache_mode_entry(unsigned entry, enum page_cache_mode cache);
>
> This new interface cannot be defined in this common header file since
> page_cache_mode is only defined in x86.  It should be defined in x86
> header, such as pat.h.

Oh, right you are.

Thanks,

Juergen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/