linux-kernel - RE: [PATCH] iommu/fsl: Fix warning resulting from adding PCI device twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 4 Sep 2014 10:57:59 +0000
From:	Varun Sethi <Varun.Sethi@...escale.com>
To:	Joerg Roedel <joro@...tes.org>
CC:	"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
	"alex.williamson@...hat.com" <alex.williamson@...hat.com>,
	Emilian Medve <Emilian.Medve@...escale.com>,
	"linuxppc-dev@...abs.org" <linuxppc-dev@...abs.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] iommu/fsl: Fix warning resulting from adding PCI device
 twice



> -----Original Message-----
> From: Joerg Roedel [mailto:joro@...tes.org]
> Sent: Thursday, September 04, 2014 3:44 PM
> To: Sethi Varun-B16395
> Cc: iommu@...ts.linux-foundation.org; alex.williamson@...hat.com; Medve
> Emilian-EMMEDVE1; linuxppc-dev@...abs.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] iommu/fsl: Fix warning resulting from adding PCI device
> twice
> 
> On Thu, Sep 04, 2014 at 11:33:42AM +0530, Varun Sethi wrote:
> > +	if (!iommu_group_get(dev))
> > +		ret = iommu_group_add_device(group, dev);
> >
> >  	iommu_group_put(group);
> >  	return ret;
> 
> Doesn't this additional call to iommu_group_get take a reference to the
> iommu_group that needs to be released?
Yes, you are right this would take a reference to the group that should be released. I need to add iommu_group_put for decrementing the reference count. Will post a new patch.

Thanks,
Varun


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/