linux-kernel - Re: [PATCH v2 4/5] arm64: Introduce dummy version of asm/fiq.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 5 Sep 2014 17:50:33 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Daniel Thompson <daniel.thompson@...aro.org>
Cc:	Russell King <linux@....linux.org.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"patches@...aro.org" <patches@...aro.org>,
	"linaro-kernel@...ts.linaro.org" <linaro-kernel@...ts.linaro.org>,
	John Stultz <john.stultz@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Sumit Semwal <sumit.semwal@...aro.org>,
	Will Deacon <Will.Deacon@....com>
Subject: Re: [PATCH v2 4/5] arm64: Introduce dummy version of asm/fiq.h

On Fri, Sep 05, 2014 at 04:33:17PM +0100, Daniel Thompson wrote:
> Drivers that are shared between arm and arm64 and which employ
> FIQ on arm cannot include asm/fiq.h without #ifdef'ing. This patch
> introduces a dummy version of asm/fiq.h to arm64 to avoid this.
> 
> Signed-off-by: Daniel Thompson <daniel.thompson@...aro.org>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Will Deacon <will.deacon@....com>
> ---
>  arch/arm64/include/asm/fiq.h | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 arch/arm64/include/asm/fiq.h
> 
> diff --git a/arch/arm64/include/asm/fiq.h b/arch/arm64/include/asm/fiq.h
> new file mode 100644
> index 0000000..909ec54
> --- /dev/null
> +++ b/arch/arm64/include/asm/fiq.h
> @@ -0,0 +1,18 @@
> +/*
> + * arch/arm64/include/asm/fiq.h
> + *
> + * Placeholder to reduce #ifdef'ing in shared arm/arm64 drivers.
> + */
> +
> +#ifndef __ASM_FIQ_H
> +#define __ASM_FIQ_H
> +
> +/*
> + * This placeholder allows code of the following form to be simplified:
> + *
> + * #ifdef CONFIG_FIQ
> + * #include <asm/fiq.h>
> + * #endif
> + */
> +
> +#endif

OK, we add a dummy file, but please keep it simple. Comments are fine
but no need for header guards (nor the file name, on arm64 we try to get
rid of them, though some still slip through).

Thanks.

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/