linux-kernel - Re: [PATCH 1/3] staging: lustre: fix function definition style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 8 Sep 2014 12:40:03 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Spencer Baugh <sbaugh@...rew.cmu.edu>
Cc:	Oleg Drokin <oleg.drokin@...el.com>,
	Niu Yawei <yawei.niu@...el.com>,
	Masanari Iida <standby24x7@...il.com>,
	Hongchao Zhang <hongchao.zhang@...el.com>,
	"open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] staging: lustre: fix function definition style

On Sat, Sep 06, 2014 at 01:38:27PM -0400, Spencer Baugh wrote:
> Fix errors reported by checkpatch of this kind:
> ERROR: open brace '{' following function declarations go on the next line
> 
> Signed-off-by: Spencer Baugh <sbaugh@...rew.cmu.edu>
> ---
>  drivers/staging/lustre/lustre/include/lustre_import.h | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/include/lustre_import.h b/drivers/staging/lustre/lustre/include/lustre_import.h
> index 8304a55..feb4291 100644
> --- a/drivers/staging/lustre/lustre/include/lustre_import.h
> +++ b/drivers/staging/lustre/lustre/include/lustre_import.h
> @@ -346,21 +346,24 @@ static inline unsigned int at_timeout2est(unsigned int val)
>  	return (max((val << 2) / 5, 5U) - 4);
>  }
>  
> -static inline void at_reset(struct adaptive_timeout *at, int val) {
> +static inline void at_reset(struct adaptive_timeout *at, int val) 

You are adding whitespace errors with this patch, I can't take this
series because of this :(

Please always run your patches through scripts/checkpatch.pl to ensure
you aren't adding new problems.

Can you fix this series of patches up and resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/