linux-kernel - Re: [PATCH] drivers: staging: lustre: Fix "space prohibited after that open parenthesis '('" errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 08 Sep 2014 15:38:01 -0700
From:	Joe Perches <joe@...ches.com>
To:	Greg Donald <gdonald@...il.com>
Cc:	Greg Kroah-Hartman <greg@...ah.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Oleg Drokin <oleg.drokin@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: lustre: Fix "space prohibited after
 that open parenthesis '('" errors

On Mon, 2014-09-08 at 17:32 -0500, Greg Donald wrote:
> Fix checkpatch.pl "space prohibited after that open parenthesis '('" errors
[]
> diff --git a/drivers/staging/lustre/lustre/obdclass/obdo.c b/drivers/staging/lustre/lustre/obdclass/obdo.c
[]
> @@ -161,35 +161,35 @@ int obdo_cmp_md(struct obdo *dst, struct obdo *src, u32 compare)
>  {
>  	int res = 0;
>  
> -	if ( compare & OBD_MD_FLATIME )
> +	if (compare & OBD_MD_FLATIME)
>  		res = (res || (dst->o_atime != src->o_atime));

These would be nicer as

		res |= dst->o_atime != src->o_atime;

> -	if ( compare & OBD_MD_FLMTIME )
> +	if (compare & OBD_MD_FLMTIME)
>  		res = (res || (dst->o_mtime != src->o_mtime));

etc...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/