linux-kernel - Re: [PATCH 1/2] Input: atmel_mxt_ts - downgrade warning about empty interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Sep 2014 16:40:10 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	nick.dyer@...ev.co.uk
Cc:	Stephen Warren <swarren@...dotorg.org>,
	Yufeng Shen <miletus@...gle.com>,
	Daniel Kurtz <djkurtz@...omium.org>,
	Henrik Rydberg <rydberg@...omail.se>,
	Joonyoung Shim <jy0922.shim@...sung.com>,
	Alan Bowens <Alan.Bowens@...el.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Peter Meerwald <pmeerw@...erw.net>,
	Benson Leung <bleung@...omium.org>,
	Olof Johansson <olofj@...omium.org>,
	Sekhar Nori <nsekhar@...com>
Subject: Re: [PATCH 1/2] Input: atmel_mxt_ts - downgrade warning about empty
 interrupts

On Tue, Sep 09, 2014 at 03:50:48PM +0100, nick.dyer@...ev.co.uk wrote:
> From: Nick Dyer <nick.dyer@...ev.co.uk>
> 
> In the case where the CHG/interrupt line mode is not configured correctly,
> this warning is output to dmesg output for each interrupt. Downgrade the
> message to debug.
> 
> Signed-off-by: Nick Dyer <nick.dyer@...ev.co.uk>

Applied, thank you.

> ---
>  drivers/input/touchscreen/atmel_mxt_ts.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
> index db178ed..d954b81 100644
> --- a/drivers/input/touchscreen/atmel_mxt_ts.c
> +++ b/drivers/input/touchscreen/atmel_mxt_ts.c
> @@ -837,7 +837,12 @@ static irqreturn_t mxt_process_messages_t44(struct mxt_data *data)
>  	count = data->msg_buf[0];
>  
>  	if (count == 0) {
> -		dev_warn(dev, "Interrupt triggered but zero messages\n");
> +		/*
> +		 * This condition is caused by the CHG line being configured
> +		 * in Mode 0. It results in unnecessary I2C operations but it
> +		 * is benign.
> +		 */
> +		dev_dbg(dev, "Interrupt triggered but zero messages\n");
>  		return IRQ_NONE;
>  	} else if (count > data->max_reportid) {
>  		dev_err(dev, "T44 count %d exceeded max report id\n", count);
> -- 
> 1.9.1
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/