[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 09 Sep 2014 10:24:00 -0500
From: Timur Tabi <timur@...i.org>
To: Mark Brown <broonie@...nel.org>
CC: Shengjiu Wang <shengjiu.wang@...escale.com>,
nicoleotsuka@...il.com, Li.Xiubo@...escale.com,
lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.de,
alsa-devel@...a-project.org, linuxppc-dev@...ts.ozlabs.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module
On 09/09/2014 10:21 AM, Mark Brown wrote:
>> if (ssi_private->clk)
>> > clk_prepare_enable(ssi_private->clk);
> Should be a !IS_ERR() - NULL is a valid clock.
In that case, ssi_private->clk needs to be initialized to -EINVAL or
something, so that the check works on systems that don't have any clocks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists