[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 09 Sep 2014 10:05:33 -0700
From: Darren Hart <dvhart@...radead.org>
To: Weike Chen <alvin.chen@...el.com>,
Linus Walleij <linus.walleij@...aro.org>,
Alexandre Courbot <gnurou@...il.com>,
Grant Likely <grant.likely@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
atull <atull@...nsource.altera.com>
CC: <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<devicetree@...r.kernel.org>,
Boon Leong Ong <boon.leong.ong@...el.com>,
Hock Leong Kweh <hock.leong.kweh@...el.com>,
Sebastian Andrzej Siewior <sebastian@...akpoint.cc>,
Mika Westerberg <mika.westerberg@...el.com>,
Andriy Shevchenko <andriy.shevchenko@...el.com>,
Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding
to MFD driver
On 9/9/14, 11:07, "Weike Chen" <alvin.chen@...el.com> wrote:
>The Synopsys DesignWare APB GPIO driver only supports open firmware
>devices.
>But, like Intel Quark X1000 SOC, which has a single PCI function exporting
>a GPIO and an I2C controller, it is a Multifunction device. This patch is
>to enable the current Synopsys DesignWare APB GPIO driver to support the
>Multifunction device which exports the designware GPIO controller.
>
>Reviewed-by: Hock Leong Kweh <hock.leong.kweh@...el.com>
>Signed-off-by: Weike Chen <alvin.chen@...el.com>
>---
> drivers/gpio/Kconfig | 1 -
> drivers/gpio/gpio-dwapb.c | 226
>++++++++++++++++++++++--------
> include/linux/platform_data/gpio-dwapb.h | 32 +++++
> 3 files changed, 201 insertions(+), 58 deletions(-)
> create mode 100644 include/linux/platform_data/gpio-dwapb.h
>
>diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
>index 9de1515..8250a44 100644
>--- a/drivers/gpio/Kconfig
>+++ b/drivers/gpio/Kconfig
>@@ -136,7 +136,6 @@ config GPIO_DWAPB
> tristate "Synopsys DesignWare APB GPIO driver"
> select GPIO_GENERIC
> select GENERIC_IRQ_CHIP
>- depends on OF_GPIO
You cover this specific dependencies with inline ifdefs, but you lose the
CONFIG_OF depends by dropping it, and there are no such checks in the
probe routine. Assumptions of OF are not limited to probe in this driver.
While I would like to see this assumption properly abstracted, the most
expedient/immediate fix is probably to add a depends on OF above.
--
Darren
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists