[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 9 Sep 2014 12:18:24 -0700
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
Cc: Chris Zankel <chris@...kel.net>,
"Max Filippov linux-xtensa @ linux-xtensa . org" <jcmvbkbc@...il.com>,
linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH 2/2] xtensa/uapi: Add definition of TIOC[SG]RS485
On Tue, Sep 09, 2014 at 07:20:56AM +0200, Ricardo Ribalda Delgado wrote:
> Commit: e676253b19b2d269cccf67fdb1592120a0cd0676 [3/21] serial/8250: Add
> support for RS485 IOCTLs, adds support for RS485 ioctls for 825_core on
> all the archs. Unfortunaltely the definition of TIOCSRS485 and
> TIOCGRS485 was missing on the ioctls.h file
>
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
> ---
> arch/xtensa/include/uapi/asm/ioctls.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/xtensa/include/uapi/asm/ioctls.h b/arch/xtensa/include/uapi/asm/ioctls.h
> index a47909f..accda82 100644
> --- a/arch/xtensa/include/uapi/asm/ioctls.h
> +++ b/arch/xtensa/include/uapi/asm/ioctls.h
> @@ -95,6 +95,8 @@
> #define TCSETS2 _IOW('T', 43, struct termios2)
> #define TCSETSW2 _IOW('T', 44, struct termios2)
> #define TCSETSF2 _IOW('T', 45, struct termios2)
> +#define TIOCGRS485 0x542E
> +#define TIOCSRS485 0x542F
Like your patches for other arches, please use a _IOW() macro here, not a "number".
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists