[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 9 Sep 2014 22:36:19 +0200 (CEST)
From: Guennadi Liakhovetski <g.liakhovetski@....de>
To: Mauro Carvalho Chehab <m.chehab@...sung.com>
cc: Linux Media Mailing List <linux-media@...r.kernel.org>,
Mauro Carvalho Chehab <mchehab@...radead.org>,
linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCHv3 1/3] [media] disable OMAP1 COMPILE_TEST
Thanks, Mauro,
On Tue, 9 Sep 2014, Mauro Carvalho Chehab wrote:
> This driver depends on a legacy OMAP DMA API. So, it won't
> compile-test on other archs.
>
> While we might add stubs to the functions, this is not a
> good idea, as the hole API should be replaced.
>
> So, for now, let's just remove COMPILE_TEST and wait for
> some time for people to fix. If not fixed, then we'll end
> by removing this driver as a hole.
>
> Signed-off-by: Mauro Carvalho Chehab <m.chehab@...sung.com>
Acked-by: Guennadi Liakhovetski <g.liakhovetski@....de>
Regards
Guennadi
>
> diff --git a/drivers/media/platform/soc_camera/Kconfig b/drivers/media/platform/soc_camera/Kconfig
> index 6af6c6dccda8..f2776cd415ca 100644
> --- a/drivers/media/platform/soc_camera/Kconfig
> +++ b/drivers/media/platform/soc_camera/Kconfig
> @@ -63,7 +63,7 @@ config VIDEO_SH_MOBILE_CEU
> config VIDEO_OMAP1
> tristate "OMAP1 Camera Interface driver"
> depends on VIDEO_DEV && SOC_CAMERA
> - depends on ARCH_OMAP1 || COMPILE_TEST
> + depends on ARCH_OMAP1
> depends on HAS_DMA
> select VIDEOBUF_DMA_CONTIG
> select VIDEOBUF_DMA_SG
> --
> 1.9.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists