linux-kernel - Re: [PATCH/RESEND] tty: serial: msm: Add DT based earlycon support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Sep 2014 20:56:12 -0500
From:	Rob Herring <robh@...nel.org>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-arm-msm <linux-arm-msm@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH/RESEND] tty: serial: msm: Add DT based earlycon support

On Thu, Sep 11, 2014 at 5:14 PM, Stephen Boyd <sboyd@...eaurora.org> wrote:
> Add support for DT based early console on platforms with the msm
> serial hardware.
>
> Cc: Rob Herring <robh@...nel.org>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>

One comment, but looks good to me.

Acked-by: Rob Herring <robh@...nel.org>

> +static int __init
> +msm_serial_early_console_setup(struct earlycon_device *device, const char *opt)
> +{
> +       if (!device->port.membase)
> +               return -ENODEV;
> +
> +       device->con->write = msm_serial_early_write;
> +       return 0;
> +}
> +OF_EARLYCON_DECLARE(msm_serial, "qcom,msm-uart",
> +                   msm_serial_early_console_setup);

Don't you want to support kernel command line as well? Then if you
can't change the DT or bootloader's command line, you can add it into
the kernel build with the appended command line. Don't forget to
document it in kernel-parameters.txt if you do.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/