| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 14 Sep 2014 18:54:19 +0800 From: Chen Gang <gang.chen.5i5j@...il.com> To: konrad.wilk@...cle.com, boris.ostrovsky@...cle.com, David Vrabel <david.vrabel@...rix.com>, stefano.stabellini@...citrix.com, mukesh.rathor@...cle.com CC: xen-devel@...ts.xenproject.org, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 1/4] drivers/xen/xenbus/xenbus_client.c: Remove redundancy asignment to 'addr' Oh, sorry, for subject, need use 'assignment' instead of 'asignment'. On 09/14/2014 06:49 PM, Chen Gang wrote: > When failure occurs, 'node' is already set to NULL, and it is enough > for next checking (which will return in time), so need not set 'addr'. > > Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com> > --- > drivers/xen/xenbus/xenbus_client.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/xen/xenbus/xenbus_client.c b/drivers/xen/xenbus/xenbus_client.c > index 439c9dc..277e74d 100644 > --- a/drivers/xen/xenbus/xenbus_client.c > +++ b/drivers/xen/xenbus/xenbus_client.c > @@ -636,7 +636,7 @@ static int xenbus_unmap_ring_vfree_hvm(struct xenbus_device *dev, void *vaddr) > goto found; > } > } > - node = addr = NULL; > + node = NULL; > found: > spin_unlock(&xenbus_valloc_lock); > > -- Chen Gang Open share and attitude like air water and life which God blessed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists