linux-kernel - Re: [PATCH] sound: pci: ctxfi: pr_* replaced with dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 15 Sep 2014 10:28:44 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound: pci: ctxfi: pr_* replaced with dev_*

At Fri, 12 Sep 2014 16:15:45 +0530,
Sudip Mukherjee wrote:
> 
> pr_* macros replaced with dev_* as they are more preffered over pr_*.

Now we have card->dev as its own device.  Use this instead of
pci->dev as much as possible.  (Of course, you should be careful about
the object's lifetime, too).  Also...

> diff --git a/sound/pci/ctxfi/ctamixer.c b/sound/pci/ctxfi/ctamixer.c
> index fed6e6a..d08b8b6 100644
> --- a/sound/pci/ctxfi/ctamixer.c
> +++ b/sound/pci/ctxfi/ctamixer.c
> @@ -258,7 +258,8 @@ static int get_amixer_rsc(struct amixer_mgr *mgr,
>  	}
>  	spin_unlock_irqrestore(&mgr->mgr_lock, flags);
>  	if (err) {
> -		pr_err("ctxfi: Can't meet AMIXER resource request!\n");
> +		dev_err(&(((struct hw *)(mgr->mgr.hw))->pci->dev),
> +			"ctxfi: Can't meet AMIXER resource request!\n");

... please re-read and consider twice before submitting your patch,
whether such a change is really good or not.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/