linux-kernel - Re: [PATCH v3] tty: serial: men_z135_uart: Fix driver for changes in hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 17 Sep 2014 12:54:33 +0200
From:	Johannes Thumshirn <johannes.thumshirn@....de>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>
CC:	<linux-serial@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Johannes Thumshirn <johannes.thumshirn@....de>
Subject: Re: [PATCH v3] tty: serial: men_z135_uart: Fix driver for changes in
 hardware

On Tue, Sep 16, 2014 at 07:24:28AM +0200, Johannes Thumshirn wrote:
> 16z135 IP Core has changed so the driver needs to be updated to respect
> these changes. The following changes have been made:
>
> * Don't invert the 16z135 modem status register when reading.
> * Add module parameter to configure the (baud rate dependent) RX timeout.
>   Character timeout in seconds = (timeout_reg * baud_reg * 4)/freq_reg.
> * Enable the handling of UART core's automatic flow control feature.
>   When AFE is active disable generation of modem status IRQs.
> * Rework the handling of IRQs to be conform with newer FPGA versions and
>   take precautions not to miss an interrupt because of the destructive read
>   of the IIR register.
> * Correct men_z135_handle_modem_status(), MSR is stat_reg[15:8] not
>   stat_reg[7:0]
>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@....de>
> ---
> Changes to v1:
> Incorporated comments of Jiri Slaby:
>
> * Timeout value is documented in module parameter description
> * rx_timeout variable is uint
> * Changed IRQ handled variable to bool
> * Changed if statement for RDA or CTI IRQ
>
> Changes to v2:
> Correct men_z135_handle_modem_status(), MSR is stat_reg[15:8] not stat_reg[7:0]

We've found a bug in this patch during our tests so please do not en-queue it yet.

Sorry for the inconvenience.

Thanks,
Johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/