lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Sep 2014 11:04:16 +0900 From: jonghwa3.lee@...sung.com To: Vikas Sajjan <vikas.sajjan@...sung.com> Cc: linux-samsung-soc <linux-samsung-soc@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, linux-kernel@...r.kernel.org, Kukjin Kim <kgene.kim@...sung.com> Subject: Re: [RESEND PATCH] arm: exynos: Allow rtc alarm and tick wakeup irq for exynos3250. On 2014년 09월 17일 17:53, Vikas Sajjan wrote: > Hi, > > On Wed, Sep 17, 2014 at 8:52 AM, Jonghwa Lee <jonghwa3.lee@...sung.com> wrote: >> Add rtc alarm and tick irq to wakeup sources in exynos3250. >> >> Signed-off-by: Jonghwa Lee <jonghwa3.lee@...sung.com> >> Acked-by : Chanwoo choi <cw00.choi@...sung.com> >> --- >> arch/arm/mach-exynos/pm.c | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-exynos/pm.c b/arch/arm/mach-exynos/pm.c >> index fa7218a..d78dcf9 100644 >> --- a/arch/arm/mach-exynos/pm.c >> +++ b/arch/arm/mach-exynos/pm.c >> @@ -66,6 +66,12 @@ static struct sleep_save exynos_core_save[] = { >> >> static u32 exynos_irqwake_intmask = 0xffffffff; >> >> +static const struct exynos_wkup_irq exynos3250_wkup_irq[] = { >> + { 105, BIT(1) }, /* RTC alarm */ >> + { 106, BIT(2) }, /* RTC tick */ >> + { /* sentinel */ }, >> +}; >> + >> static const struct exynos_wkup_irq exynos4_wkup_irq[] = { >> { 76, BIT(1) }, /* RTC alarm */ >> { 77, BIT(2) }, /* RTC tick */ >> @@ -81,9 +87,10 @@ static const struct exynos_wkup_irq exynos5250_wkup_irq[] = { >> static int exynos_irq_set_wake(struct irq_data *data, unsigned int state) >> { >> const struct exynos_wkup_irq *wkup_irq; >> - >> if (soc_is_exynos5250()) >> wkup_irq = exynos5250_wkup_irq; >> + else if (soc_is_exynos3250()) >> + wkup_irq = exynos3250_wkup_irq; > > > Don't add anymore soc_is_exynosxxx() checks, please rebase on [1], > which refactors the pm.c to use DT based lookup. > > [1] http://www.spinics.net/lists/arm-kernel/msg355266.html > Okay, I'll wait those patches are merged, then I'll rebase and repost it. Thanks, Jonghwa. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists