linux-kernel - Re: [PATCH] gpio: samsung: Remove remaining check for CONFIG_S5P_GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Sep 2014 21:34:27 +0200
From:	Tomasz Figa <tomasz.figa@...il.com>
To:	Paul Bolle <pebolle@...cali.nl>,
	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>
CC:	Arnd Bergmann <arnd@...db.de>, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: samsung: Remove remaining check for CONFIG_S5P_GPIO_DRVSTR

Paul,

On 18.09.2014 10:57, Paul Bolle wrote:
> On Thu, 2014-09-04 at 18:03 +0200, Arnd Bergmann wrote:
>> On Thursday 04 September 2014, Paul Bolle wrote: 
>>> That check for CONFIG_S5P_GPIO_DRVSTR is still present in v3.17-rc3 and
>>> next-20140903. Should I submit the trivial patch to remove it (and the
>>> dead code it hides)?
>>
>> Yes, I think this one is an obvious candidate for removal.
> 
> Still there in v3.17-rc5 and next-20140918. So I submit yet another
> trivial cleanup.
> 
> Done on top of next-20140918. Only tested by grepping the tree. Please
> note that, obviously, nothing uses s5p_gpio_get_drvstr() or
> s5p_gpio_set_drvstr().
> 
> 
> Paul Bolle
> -------->8--------
> From: Paul Bolle <pebolle@...cali.nl>
> 
> Commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
> removed the Kconfig symbol S5P_GPIO_DRVSTR. It didn't remove one check
> for the related macro. Remove that check and the dead code it hides.
> 
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>

Thanks for the patch.

Reviewed-by: Tomasz Figa <tomasz.figa@...il.com>

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/