linux-kernel - Re: [PATCH v2 0/3] iio: exynos-adc: use syscon instead of ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 21 Sep 2014 13:17:06 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Naveen Krishna Chatradhi <ch.naveen@...sung.com>,
	linux-iio@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	devicetree@...r.kernel.org
CC:	linux-kernel@...r.kernel.org, cw00.choi@...sung.com,
	gregkh@...uxfoundation.org, naveenkrishna.ch@...il.com,
	lars@...afoo.de, cpgs@...sung.com, grundler@...omium.org,
	Kukjin Kim <kgene.kim@...sung.com>
Subject: Re: [PATCH v2 0/3] iio: exynos-adc: use syscon instead of ioremap

On 16/09/14 09:58, Naveen Krishna Chatradhi wrote:
> Changes since v1:
> 1. Rebased on top of togreg branch of IIO git.
> 
> This patch set does the following
> 1. Use the syscon and Regmap API instead of ioremappaing the
>    ADC_PHY register from PMU.
> 2. Updates the Documentation in exynos-adc.txt with syscon phandle
>    for the ADC nodes.
> 3. Updates the Dts files for Exynos3250, Exynos4x12, Exynos5250,
>    Exynos5420 with the syscon phandle.
> 
> Tested on Exynos5420 based Peach PIT and Exynos5800 based Peach PI
> by verifying sysfs entries provided by HWMON based NTC thermistors.
> 
> Tested-By for Exynos3250, Exynos4x12 would be appreciated.
Would definitely be good!

The main issue I have with this series is that it breaks backward
compatibility with old device trees and newer kernels.

Now I appreciate that sometimes there are reasons to do it but want this
to have deeper consideration (and acks to show it) from the Exynos side
of things and preferably from the device tree side of things as well.

cc'd Kukjin Kim for the Exynos side of things as the listed Maintainer.

Otherwise, the series looks fine to me.
> 
> Naveen Krishna Chatradhi (3):
>   iio: exyno-adc: use syscon for PMU register access
>   Documentation: dt-bindings: update exynos-adc.txt with syscon handle
>   ARM: dts: exynos: Add sysreg phandle to ADC node
> 
>  .../devicetree/bindings/arm/samsung/exynos-adc.txt |    9 ++++--
>  arch/arm/boot/dts/exynos3250.dtsi                  |    3 +-
>  arch/arm/boot/dts/exynos4x12.dtsi                  |    3 +-
>  arch/arm/boot/dts/exynos5250.dtsi                  |    3 +-
>  arch/arm/boot/dts/exynos5420.dtsi                  |    3 +-
>  drivers/iio/adc/exynos_adc.c                       |   30 ++++++++++++++------
>  6 files changed, 36 insertions(+), 15 deletions(-)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/