linux-kernel - Re: [PATCH] sched/numa: kill the wrong/dead TASK_DEAD check in task_numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 22 Sep 2014 07:54:17 +0100
From:	Mel Gorman <mgorman@...e.de>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Rik van Riel <riel@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/numa: kill the wrong/dead TASK_DEAD check in
 task_numa_fault()

On Sun, Sep 21, 2014 at 09:47:43PM +0200, Oleg Nesterov wrote:
> current->state == TASK_DEAD means that the task is doing its last
> schedule(), page fault is obviously impossible at this stage.
> 
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>

I was going to complain that the check would protect against a spurious
allocation during fault but a task in this state should not be faulting
any more.

Acked-by: Mel Gorman <mgorman@...e.de>

Thanks.

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/