linux-kernel - [PATCH] scsi: sas_ata: change ata_<foo>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 22 Sep 2014 10:01:24 -0700
From:	Joe Perches <joe@...ches.com>
To:	"James E.J. Bottomley" <JBottomley@...allels.com>
Cc:	Dan Williams <dan.j.williams@...el.com>,
	Todd Brandt <todd.e.brandt@...el.com>,
	Tejun Heo <tj@...nel.org>, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] scsi: sas_ata: change ata_<foo>_printk routines to return
 void

The return value is not used by callers of this function
so change the function to return void.

Signed-off-by: Joe Perches <joe@...ches.com>
---
This change is associated to a desire to eventually
change printk to return void.

 drivers/scsi/libsas/sas_ata.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
index 766098a..2a15a54 100644
--- a/drivers/scsi/libsas/sas_ata.c
+++ b/drivers/scsi/libsas/sas_ata.c
@@ -375,26 +375,23 @@ static int local_ata_check_ready(struct ata_link *link)
 	}
 }
 
-static int sas_ata_printk(const char *level, const struct domain_device *ddev,
-			  const char *fmt, ...)
+static void sas_ata_printk(const char *level, const struct domain_device *ddev,
+			   const char *fmt, ...)
 {
 	struct ata_port *ap = ddev->sata_dev.ap;
 	struct device *dev = &ddev->rphy->dev;
 	struct va_format vaf;
 	va_list args;
-	int r;
 
 	va_start(args, fmt);
 
 	vaf.fmt = fmt;
 	vaf.va = &args;
 
-	r = printk("%ssas: ata%u: %s: %pV",
-		   level, ap->print_id, dev_name(dev), &vaf);
+	printk("%ssas: ata%u: %s: %pV",
+	       level, ap->print_id, dev_name(dev), &vaf);
 
 	va_end(args);
-
-	return r;
 }
 
 static int sas_ata_hard_reset(struct ata_link *link, unsigned int *class,


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/