linux-kernel - Re: [PATCH] modify error code when perf_session_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 23 Sep 2014 14:02:31 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	taeung <treeze.taeung@...il.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	linux-kernel@...r.kernel.org, namhyung@...nel.org,
	linux-perf-users@...r.kernel.org
Subject: Re: [PATCH] modify error code when perf_session__new() fail.

hi,
subject should start with 'perf tools:'

On Tue, Sep 23, 2014 at 03:12:17PM +0900, taeung wrote:
> 	Because perf_session__new() could fail
> 	for more reasons than just ENOMEM,
> 	I modified error code(ENOMEM or EINVAL)
> 	into -1.

why the indent?

> 
> Signed-off-by: taeung <treeze.taeung@...il.com>

the log message needs some love, but the patch looks ok

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/