linux-kernel - Re: [PATCH] mm, debug: mm-introduce-vm_bug_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Sep 2014 12:19:49 -0400
From:	Valdis.Kletnieks@...edu
To:	Michal Hocko <mhocko@...e.cz>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	mm-commits@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, linux-fsdevel@...r.kernel.org,
	linux-next@...r.kernel.org, sfr@...b.auug.org.au,
	Sasha Levin <sasha.levin@...cle.com>
Subject: Re: [PATCH] mm, debug: mm-introduce-vm_bug_on_mm-fix-fix.patch

On Tue, 23 Sep 2014 13:28:48 +0200, Michal Hocko said:
> And there is another one hitting during randconfig. The patch makes my
> eyes bleed

Amen.  But I'm not seeing a better fix either.

>  #if defined(CONFIG_NUMA_BALANCING) || defined(CONFIG_COMPACTION)
> -		"tlb_flush_pending %d\n",
> +		"tlb_flush_pending %d\n"
>  #endif
> -		mm, mm->mmap, mm->vmacache_seqnum, mm->task_size,
> +		, mm, mm->mmap, mm->vmacache_seqnum, mm->task_size,

I'm surprised that checkpatch doesn't explode on this.  And I'm starting
a pool on how soon somebody submits a patch to "fix" this. :)

Content of type "application/pgp-signature" skipped