lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 25 Sep 2014 10:05:08 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Vinod Koul <vinod.koul@...el.com>
Cc:	linux-kernel@...r.kernel.org, subhransu.s.prusty@...el.com,
	MyungJoo Ham <myungjoo.ham@...sung.com>,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH 03/27] extcon: arizona: use
 pm_runtime_last_busy_and_autosuspend helper

On 09/25/2014 01:14 AM, Vinod Koul wrote:
> Use the new pm_runtime_last_busy_and_autosuspend helper instead of open
> coding the same code
> 
> Signed-off-by: Vinod Koul <vinod.koul@...el.com>
> ---
>  drivers/extcon/extcon-arizona.c |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index ba51588..7774e80 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -323,8 +323,7 @@ static void arizona_stop_mic(struct arizona_extcon_info *info)
>  
>  	if (change) {
>  		regulator_disable(info->micvdd);
> -		pm_runtime_mark_last_busy(info->dev);
> -		pm_runtime_put_autosuspend(info->dev);
> +		pm_runtime_last_busy_and_autosuspend(info->dev);
>  	}
>  }
>  
> @@ -1077,8 +1076,7 @@ out:
>  
>  	mutex_unlock(&info->lock);
>  
> -	pm_runtime_mark_last_busy(info->dev);
> -	pm_runtime_put_autosuspend(info->dev);
> +	pm_runtime_last_busy_and_autosuspend(info->dev);
>  
>  	return IRQ_HANDLED;
>  }
> 

Looks good to me about this patch.

Acked-by: Chanwoo Choi <cw00.choi@...sung.com>

Thanks,
Chanwoo Choi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ