linux-kernel - RE: [PATCH 1/1] PWM-atmel: Fixed a bug which set the pwm clock prescaler incorrectly. In the defect code the prescaler was always one more than expected value, which resulted in the pwm output with wrong frequency and duty cycle.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 25 Sep 2014 14:44:48 +0000
From:	"Yang, Robert" <RYang@...h.com>
To:	Thierry Reding <thierry.reding@...il.com>,
	"hachyang@...il.com" <hachyang@...il.com>
CC:	"linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Nikolaus Voss <n.voss@...nmann-emt.de>
Subject: RE: [PATCH 1/1] PWM-atmel: Fixed a bug which set the pwm clock
 prescaler incorrectly. In the defect code the prescaler was always one more
 than expected value, which resulted in the pwm output with wrong frequency
 and duty cycle.

Hi Thierry,

I agree Nikolaus's fix is more efficient and works too.

Robert

-----Original Message-----
From: Thierry Reding [mailto:thierry.reding@...il.com]
Sent: Thursday, September 25, 2014 1:55 AM
To: hachyang@...il.com
Cc: linux-pwm@...r.kernel.org; linux-kernel@...r.kernel.org; Yang, Robert; Nikolaus Voss
Subject: Re: [PATCH 1/1] PWM-atmel: Fixed a bug which set the pwm clock prescaler incorrectly. In the defect code the prescaler was always one more than expected value, which resulted in the pwm output with wrong frequency and duty cycle.

On Wed, Sep 10, 2014 at 03:35:19PM -0600, hachyang@...il.com wrote:
> From: ryang <ryang@...h.com>
>
> Signed-off-by: ryang <ryang@...h.com>
> ---
>  drivers/pwm/pwm-atmel.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c index
> 6e700a5..2dca0bf 100644
> --- a/drivers/pwm/pwm-atmel.c
> +++ b/drivers/pwm/pwm-atmel.c
> @@ -128,7 +128,8 @@ static int atmel_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
>                       return -EINVAL;
>               }
>       }
> -
> +     /* Need to reduce the prescaler by 1 */
> +     pres--;
>       /* Calculate the duty cycles */
>       prd = div;
>       div *= duty_ns;
> --
> 1.9.1

I think this was fixed by a different patch by Nikolaus in a more direct way, see: https://lkml.org/lkml/2014/9/24/28

I've pushed that patch to the for-next branch of the PWM tree. Can you verify that the issue you were seeing is gone?

Thierry
Please be advised that this email may contain confidential information. If you are not the intended recipient, please notify us by email by replying to the sender and delete this message. The sender disclaims that the content of this email constitutes an offer to enter into, or the acceptance of, any agreement; provided that the foregoing does not invalidate the binding effect of any digital or other electronic reproduction of a manual signature that is included in any attachment.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/