linux-kernel - Re: [PATCH] video: fbdev: sis: sis_main.c: Cleaning up missing null-terminate in conjunction with strncpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 30 Sep 2014 13:01:00 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Thomas Winischhofer <thomas@...ischhofer.net>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
CC:	<linux-fbdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] video: fbdev: sis: sis_main.c:  Cleaning up missing null-terminate
 in conjunction with strncpy

On 14/09/14 20:35, Rickard Strandqvist wrote:
> Replacing strncpy with strlcpy to avoid strings that lacks null terminate.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>  drivers/video/fbdev/sis/sis_main.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c
> index 3f12a2d..1f4c216 100644
> --- a/drivers/video/fbdev/sis/sis_main.c
> +++ b/drivers/video/fbdev/sis/sis_main.c
> @@ -5830,7 +5830,7 @@ static int sisfb_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>  			ivideo->cardnumber++;
>  	}
>  
> -	strncpy(ivideo->myid, chipinfo->chip_name, 30);
> +	strlcpy(ivideo->myid, chipinfo->chip_name, sizeof(ivideo->myid));
>  
>  	ivideo->warncount = 0;
>  	ivideo->chip_id = pdev->device;
> 

Thanks, queued for 3.18.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)