linux-kernel - Re: [PATCH] staging: et131x: remove unneccessary 'out of memory' message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Sep 2014 14:40:10 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	Karthik Nayak <karthik.188@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	devel@...verdev.osuosl.org, gamerh2o@...il.com,
	Mark Einon <mark.einon@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] staging: et131x: remove unneccessary 'out of memory' message

On Tue, Sep 30, 2014 at 2:19 PM, Karthik Nayak <karthik.188@...il.com> wrote:
> Removes the 'out of memory' warning issues by checkpatch
>
> Signed-off-by: Karthik Nayak <karthik.188@...il.com>
> ---
>  drivers/staging/et131x/et131x.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
> index 41fcaa0..f1a9296 100644
> --- a/drivers/staging/et131x/et131x.c
> +++ b/drivers/staging/et131x/et131x.c
> @@ -2423,7 +2423,6 @@ static struct rfd *nic_rx_pkts(struct et131x_adapter *adapter)
>
>         skb = dev_alloc_skb(rfd->len + 2);
>         if (!skb) {
> -               dev_err(&adapter->pdev->dev, "Couldn't alloc an SKB for Rx\n");
>                 return NULL;
>         }

Then you could also remove the braces:

if (!skb)
      return NULL;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/