linux-kernel - Re: [PATCH] ARC: [plat-arcfpga]: remove unused Kconfig params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 01 Oct 2014 12:12:06 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Michael Opdenacker <michael.opdenacker@...e-electrons.com>
Cc:	vgupta@...opsys.com, richard@....at, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARC: [plat-arcfpga]: remove unused Kconfig params

On Wed, 2014-10-01 at 11:59 +0200, Michael Opdenacker wrote:
> This removes the ARC_BOARD_ANGEL4 and ARC_BOARD_ML509
> Kconfig parameters which are no longer used anywhere
> in the source code and Makefiles.
> 
> This also updates a comment refering to these parameters.
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@...e-electrons.com>
> ---

See commit 774b689502d4 ("ARC: [arcfpga] Get rid of ARC_BOARD_ANGEL4 and
ARC_BOARD_ML509") in linux-next since yesterday.

>  arch/arc/plat-arcfpga/Kconfig | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/arch/arc/plat-arcfpga/Kconfig b/arch/arc/plat-arcfpga/Kconfig
> index b9f34cf55acf..3f6814aa97ac 100644
> --- a/arch/arc/plat-arcfpga/Kconfig
> +++ b/arch/arc/plat-arcfpga/Kconfig
> @@ -12,23 +12,10 @@ menuconfig ARC_PLAT_FPGA_LEGACY
>  	help
>  	  Support for ARC development boards, provided by Synopsys.
>  	  These are based on FPGA or ISS. e.g.
> -	  - ARCAngel4
> -	  - ML509
>  	  - MetaWare ISS

It doesn't follow from the fact that these Kconfig symbols are unused
that this help text is now incorrect. How did you establish that?
 
>  if ARC_PLAT_FPGA_LEGACY
>  
> -config ARC_BOARD_ANGEL4
> -	bool "ARC Angel4"
> -	default y
> -	help
> -	  ARC Angel4 FPGA Ref Platform (Xilinx Virtex Based)
> -
> -config ARC_BOARD_ML509
> -	bool "ML509"
> -	help
> -	  ARC ML509 FPGA Ref Platform (Xilinx Virtex-5 Based)
> -
>  config ISS_SMP_EXTN
>  	bool "ARC SMP Extensions (ISS Models only)"
>  	default n


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/