linux-kernel - Re: [PATCH] drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 06 Oct 2014 21:07:48 +0800
From:	Chen Gang <gang.chen.5i5j@...il.com>
To:	Thierry Reding <thierry.reding@...il.com>
CC:	linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS_IOMEM

On 10/6/14 18:08, Thierry Reding wrote:
> On Sat, Oct 04, 2014 at 05:48:42PM +0800, Chen Gang wrote:
>> PWM_CLPS711X needs HAS_IOMEM, so depend on it, the related error (with
>> allmodconfig under um):
>>
>>     MODPOST 1205 modules
>>   ERROR: "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined!
>>   ERROR: "devm_ioremap" [drivers/net/phy/mdio-bcm-unimac.ko] undefined!
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
>> ---
>>  drivers/pwm/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
>> index 3865dfb..de1ffb5 100644
>> --- a/drivers/pwm/Kconfig
>> +++ b/drivers/pwm/Kconfig
>> @@ -82,7 +82,7 @@ config PWM_BFIN
>>  
>>  config PWM_CLPS711X
>>  	tristate "CLPS711X PWM support"
>> -	depends on ARCH_CLPS711X || COMPILE_TEST
>> +	depends on (ARCH_CLPS711X || COMPILE_TEST) && HAS_IOMEM
> 
> Applied, thanks. I modified this slightly and put HAS_IOMEM on a line of
> its own. This is in my opinion (slightly) more readable and matches what
> we already have for other drivers.
> 

It is OK to me, thank you for your work.


-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/