linux-kernel - Re: [PATCH 4/6] mfd: use mfd_add_hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Oct 2014 10:24:24 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Johan Hovold <johan@...nel.org>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Jiri Kosina <jkosina@...e.cz>, linux-input@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 4/6] mfd: use mfd_add_hotplug_devices helper

On Fri, 26 Sep 2014, Johan Hovold wrote:

> Use mfd_add_hotplug_devices helper to register the subdevices.
> 
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---
>  drivers/mfd/rtsx_usb.c   | 4 ++--
>  drivers/mfd/viperboard.c | 5 ++---
>  2 files changed, 4 insertions(+), 5 deletions(-)

Applied for v3.19.

> diff --git a/drivers/mfd/rtsx_usb.c b/drivers/mfd/rtsx_usb.c
> index 78073e4b87e4..5b17339fce7c 100644
> --- a/drivers/mfd/rtsx_usb.c
> +++ b/drivers/mfd/rtsx_usb.c
> @@ -647,8 +647,8 @@ static int rtsx_usb_probe(struct usb_interface *intf,
>  	/* initialize USB SG transfer timer */
>  	setup_timer(&ucr->sg_timer, rtsx_usb_sg_timed_out, (unsigned long) ucr);
>  
> -	ret = mfd_add_devices(&intf->dev, PLATFORM_DEVID_AUTO, rtsx_usb_cells,
> -			ARRAY_SIZE(rtsx_usb_cells), NULL, 0, NULL);
> +	ret = mfd_add_hotplug_devices(&intf->dev, rtsx_usb_cells,
> +			ARRAY_SIZE(rtsx_usb_cells));
>  	if (ret)
>  		goto out_init_fail;
>  
> diff --git a/drivers/mfd/viperboard.c b/drivers/mfd/viperboard.c
> index 3c2b8f9e3c84..be450ebcb52d 100644
> --- a/drivers/mfd/viperboard.c
> +++ b/drivers/mfd/viperboard.c
> @@ -93,9 +93,8 @@ static int vprbrd_probe(struct usb_interface *interface,
>  		 version >> 8, version & 0xff,
>  		 vb->usb_dev->bus->busnum, vb->usb_dev->devnum);
>  
> -	ret = mfd_add_devices(&interface->dev, PLATFORM_DEVID_AUTO,
> -				vprbrd_devs, ARRAY_SIZE(vprbrd_devs), NULL, 0,
> -				NULL);
> +	ret = mfd_add_hotplug_devices(&interface->dev, vprbrd_devs,
> +			ARRAY_SIZE(vprbrd_devs));
>  	if (ret != 0) {
>  		dev_err(&interface->dev, "Failed to add mfd devices to core.");
>  		goto error;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/