lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 7 Oct 2014 19:13:49 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Chris Zhong <zyw@...k-chips.com>
Cc:	dianders@...omium.org, heiko@...ech.de,
	linux-rockchip@...ts.infradead.org,
	Liam Girdwood <lgirdwood@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: rk808: Add support setting suspend voltage

On Tue, Oct 07, 2014 at 04:43:57PM +0800, Chris Zhong wrote:

> @@ -100,6 +132,8 @@ static struct regulator_ops rk808_buck1_2_ops = {
>  	.disable		= regulator_disable_regmap,
>  	.is_enabled		= regulator_is_enabled_regmap,
>  	.set_ramp_delay		= rk808_set_ramp_delay,
> +	.set_suspend_voltage    = rk808_set_suspend_voltage,
> +	.set_suspend_disable    = rk808_set_suspend_disable,
>  };

Why are there only disable operations, no enable ones?  Otherwise this
all looks good.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ