linux-kernel - Re: [PATCH 1/1 linux-next] GFS2: directly return gfs2_dir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 10 Oct 2014 14:21:29 +0100
From:	Steven Whitehouse <swhiteho@...hat.com>
To:	Fabian Frederick <fabf@...net.be>, linux-kernel@...r.kernel.org
CC:	cluster-devel@...hat.com
Subject: Re: [PATCH 1/1 linux-next] GFS2: directly return gfs2_dir_check()

Hi,

On 09/10/14 21:49, Fabian Frederick wrote:
> No need to store gfs2_dir_check result and test it before returning.
>
> Signed-off-by: Fabian Frederick <fabf@...net.be>
Since I've already sent a pull request for this merge window, and this 
is not urgent, I'll keep this one and use it to start off the new tree 
in due course, once the merge window has closed. Thanks,

Steve,

> ---
>   fs/gfs2/inode.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index c4ed823..b41b5c7 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -1045,11 +1045,7 @@ static int gfs2_unlink_ok(struct gfs2_inode *dip, const struct qstr *name,
>   	if (error)
>   		return error;
>   
> -	error = gfs2_dir_check(&dip->i_inode, name, ip);
> -	if (error)
> -		return error;
> -
> -	return 0;
> +	return gfs2_dir_check(&dip->i_inode, name, ip);
>   }
>   
>   /**

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/