[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Fri, 10 Oct 2014 18:55:49 +0300
From: Sam Protsenko <semen.protsenko@...aro.org>
To: matt@...sole-pimps.org
Cc: Matt Fleming <matt.fleming@...el.com>,
Leif Lindholm <leif.lindholm@...aro.org>,
hock.leong.kweh@...el.com,
"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] efi: Capsule update support
Hi Matt,
1. Why x86 code isn't separated to another patch?
2. drivers/firmware/efi/reboot.c: efi_reboot():
One shouldn't use "printk()" with no KERN_* stuff passed into it.
I'd recommend to use "pr_info()" macro or something like that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists