[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 11 Oct 2014 19:25:18 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Mark D Rustad <mrustad@...il.com>
Cc: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
Matt Mackall <mpm@...enic.com>,
Herbert Xu <herbert@...dor.apana.org.au>,
Torsten Duwe <duwe@....de>, Theodore Ts'o <tytso@....edu>,
Jason Cooper <jason@...edaemon.net>,
Amit Shah <amit.shah@...hat.com>,
Stephen Boyd <sboyd@...eaurora.org>,
Paul Gortmaker <paul.gortmaker@...driver.com>,
Kees Cook <keescook@...omium.org>,
Dan Carpenter <dan.carpenter@...cle.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] char: hw_random: core.c: Changed from using strncpy to
strlcpy
On Sat, Oct 11, 2014 at 07:11:22PM -0700, Guenter Roeck wrote:
> On Sat, Oct 11, 2014 at 05:27:41PM -0700, Mark D Rustad wrote:
> > On Oct 11, 2014, at 3:36 PM, Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> wrote:
> >
> > > Changed from using strncpy to strlcpy to simplify the code
> >
> > Actually you changed from using strncat to strlcat.
> >
> ... and changed the length parameter along the way, making the length check
> overall quite worthless and introducing a _real_ problem.
>
Me talking nonsense; ignore this noise.
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists